Issue 109080: Upgrade the version of EMMA used to build test coverage reports

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109080: Upgrade the version of EMMA used to build test coverage reports (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by MikeSamuel

Modified:
16 years, 9 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

See the README and INSTALL files for detail. Submitted @3661

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
A	third_party/java/emma/LICENSE	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	third_party/java/emma/README	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	third_party/java/emma/emma.jar	View	Binary file		0 comments	Download
MM	third_party/java/emma/emma_ant.jar	View	Binary file		0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSamuel

On 2009/08/26 16:16:11, metaweta wrote: > LGTM David-Sarah has questions about licenses and has suggested ...

16 years, 9 months ago (2009-08-26 18:41:00 UTC) #3

metaweta

16 years, 9 months ago (2009-08-26 18:57:01 UTC) #4

On Wed, Aug 26, 2009 at 11:41 AM, <mikesamuel@gmail.com> wrote:
> On 2009/08/26 16:16:11, metaweta wrote:
>>
>> LGTM
>
> David-Sarah has questions about licenses and has suggested some
> alternate coverage tools.

Yeah, sorry--I only saw those after the review.  If people have comments on a
code review, can they use the code site?  I've been burned before by assuming
all the relevant discussion is on the ticket itself.

> I don't think those licenses are a problem since Caja never loads any
> emma code, just using it as a build tool.
>
> This change documents licensing constraints without changing any, so how
> about I commit it, and open a bug to look into coverage tools with less
> obscure licenses?
>
> http://codereview.appspot.com/109080
>

Sounds good to me.

Expand All Messages | Collapse All Messages