src/pkg/runtime/cgo/gcc_openbsd_amd64.c - Issue 109050043: code review 109050043: all: remove 'extern register M *m' from runtime

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/cgo/gcc_openbsd_amd64.c

Issue 109050043: code review 109050043: all: remove 'extern register M *m' from runtime (Closed)

Patch Set: diff -r 2699961d1143 https://code.google.com/p/go/ Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/cgo/gcc_openbsd_amd64.c

===================================================================

--- a/src/pkg/runtime/cgo/gcc_openbsd_amd64.c

+++ b/src/pkg/runtime/cgo/gcc_openbsd_amd64.c

@@ -11,7 +11,7 @@

#include "libcgo.h"

static void* threadentry(void*);

-static void (*setmg_gcc)(void*, void*);

+static void (*setg_gcc)(void*);

// TCB_SIZE is sizeof(struct thread_control_block),

// as defined in /usr/src/lib/librthread/tcb.h

@@ -83,13 +83,13 @@

}

void

-x_cgo_init(G *g, void (*setmg)(void*, void*))

+x_cgo_init(G *g, void (*setg)(void*))

{

pthread_attr_t attr;

size_t size;

void *handle;

- setmg_gcc = setmg;

+ setg_gcc = setg;

pthread_attr_init(&attr);

pthread_attr_getstacksize(&attr, &size);

g->stackguard = (uintptr)&attr - size + 4096;

@@ -159,7 +159,7 @@

* Set specific keys.

- setmg_gcc((void*)ts.m, (void*)ts.g);

+ setg_gcc((void*)ts.g);

crosscall_amd64(ts.fn);

return nil;

« no previous file with comments | « src/pkg/runtime/cgo/gcc_openbsd_386.c ('k') | src/pkg/runtime/cgo/gcc_windows_386.c » ('j') | no next file with comments »