Whitelist <video> and <audio> content.

* Add AUDIO::SRC and VIDEO::SRC to whitelist.
* Tame HTMLMediaElement, HTMLAudioElement, and HTMLVideoElement.
* Add Audio ctor.

Supporting changes:
* The PT.filter(false, identity, true, identity) pattern shall now be
  known as NP_writePolicyOnly, with comments. More refactoring to come.
* Slightly generalize handling of Image and Option ctors.

@r5470

[ihab.awad, 2013-07-02 19:41:23]

lgtm++

If there is a way to add actual test of the elements, that would be nice. Not
sure how much can be automated though....

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:4427: domClass: 'HTMLAudioElement'
Is there some logical order to where the defineElement()-s are sprinkled around?

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:4430: var element =
tameDocument.createElement('img');
Do you mean createElement('audio')?

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5348: if (width !== undefined) {
element.width = width; }
Should be (+width), etc?

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5472: return
String(privates.feral.canPlayType(String(type)));
Is our idiom String(x) or ('' + x)? Just good to be consistent either way.

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5512: if (value !== undefined) {
element.value = value; }
Should be ('' + text), etc?

[kpreid2, 2013-07-02 20:12:02]

* Add AUDIO::SRC and VIDEO::SRC to whitelist.
* Tame HTMLMediaElement, HTMLAudioElement, and HTMLVideoElement.
* Add Audio ctor.

Supporting changes:
* The PT.filter(false, identity, true, identity) pattern shall now be
  known as NP_writePolicyOnly, with comments. More refactoring to come.
* Slightly generalize handling of Image and Option ctors.

[kpreid2, 2013-07-02 20:12:07]

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:4427: domClass: 'HTMLAudioElement'
On 2013/07/02 19:41:23, ihab.awad wrote:
> Is there some logical order to where the defineElement()-s are sprinkled
around?

Alphabetical.

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:4430: var element =
tameDocument.createElement('img');
On 2013/07/02 19:41:23, ihab.awad wrote:
> Do you mean createElement('audio')?

So I do. Added a test.

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5348: if (width !== undefined) {
element.width = width; }
On 2013/07/02 19:41:23, ihab.awad wrote:
> Should be (+width), etc?

No, this is a tame element so we rely on the property taming. If it weren't, the
'return element;' at the end would be a problem.

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5472: return
String(privates.feral.canPlayType(String(type)));
On 2013/07/02 19:41:23, ihab.awad wrote:
> Is our idiom String(x) or ('' + x)? Just good to be consistent either way.

'' +, but I hope this code eventually goes the way of functional composition.

https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5512: if (value !== undefined) {
element.value = value; }
On 2013/07/02 19:41:23, ihab.awad wrote:
> Should be ('' + text), etc?

Same as above.

[kpreid2, 2013-07-02 21:05:39]

* Add AUDIO::SRC and VIDEO::SRC to whitelist.
* Tame HTMLMediaElement, HTMLAudioElement, and HTMLVideoElement.
* Add Audio ctor.

Supporting changes:
* The PT.filter(false, identity, true, identity) pattern shall now be
  known as NP_writePolicyOnly, with comments. More refactoring to come.
* Slightly generalize handling of Image and Option ctors.