Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5527)

Issue 10858049: Run "make simplify" to clean up the code a bit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by jtv.canonical
Modified:
10 years, 8 months ago
Reviewers:
dimitern, mp+173464
Visibility:
Public.

Description

Run "make simplify" to clean up the code a bit. This is something we should do periodically. It's easy to forget because, last I checked, gofmt's -s option didn't work with recursive invocations ("format my entire project"). But the Makefile hides the workaround, so it's easy enough now. I'm not entirely without self-interest: this takes some diff out of my upcoming merge proposal. https://code.launchpad.net/~jtv/juju-core/make-simplify/+merge/173464 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/azure/environprovider_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/upgrader/upgrader.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/upgrader/upgrader_test.go View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
jtv.canonical
Please take a look.
10 years, 9 months ago (2013-07-08 10:42:11 UTC) #1
dimitern
10 years, 9 months ago (2013-07-08 10:58:29 UTC) #2
LGTM, trivial.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b