Issue 10841043: Prepare for 1.2 release.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10841043: Prepare for 1.2 release. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by jcgregorio_google

Modified:
11 years, 3 months ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 2 : comments #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
M	CHANGELOG	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	apiclient/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	oauth2client/__init__.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dhermes

LGTM https://codereview.appspot.com/10841043/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.appspot.com/10841043/diff/1/CHANGELOG#newcode6 CHANGELOG:6: then include gflags as a dependency of your ...

11 years, 3 months ago (2013-07-01 20:52:46 UTC) #2

jcgregorio_google

https://codereview.appspot.com/10841043/diff/1/CHANGELOG File CHANGELOG (right): https://codereview.appspot.com/10841043/diff/1/CHANGELOG#newcode6 CHANGELOG:6: then include gflags as a dependency of your application ...

11 years, 3 months ago (2013-07-01 21:07:13 UTC) #3

jcgregorio_google

11 years, 3 months ago (2013-07-02 17:51:20 UTC) #4

On 2013/07/01 21:07:13, jcgregorio_google wrote:
> https://codereview.appspot.com/10841043/diff/1/CHANGELOG
> File CHANGELOG (right):
> 
> https://codereview.appspot.com/10841043/diff/1/CHANGELOG#newcode6
> CHANGELOG:6: then include gflags as a dependency of your application or swith
to
> On 2013/07/01 20:52:46, dhermes wrote:
> > swith --> switch
> 
> Done.
> 
> https://codereview.appspot.com/10841043/diff/1/CHANGELOG#newcode14
> CHANGELOG:14: - Use the following redirects feature of httplib2 where it
returns
> the ultimate
> On 2013/07/01 20:52:46, dhermes wrote:
> > Line length an issue? This is 81 chars.
> 
> Done.
> 
> https://codereview.appspot.com/10841043/diff/1/CHANGELOG#newcode21
> CHANGELOG:21: - The 'method' parameter for httlib2 is not positional. This
would
> cause
> On 2013/07/01 20:52:46, dhermes wrote:
> > httlib2 --> httplib2
> 
> Done.

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=ca0a9885e5...

Expand All Messages | Collapse All Messages