Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 10830045: typo check css whitelists (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by felix8a
Modified:
12 years, 8 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

this makes the css pattern generator throw an error if the css whitelist has a <foo> that isn't defined. implementing this uncovered a symbol <identifier> that isn't defined, which is used by counter-increment and counter-reset. the identifier is a global name, and we were inappropriately whitelisting counter-reset and counter-increment. this was harmless because <identifier> was undefined and ignored, but it's not harmless now that <identifier> is defined. so I'm deleting counter-increment and counter-reset from the whitelist, which is harmless because they didn't work anyway.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 6 chunks +15 lines, -2 lines 1 comment Download
M src/com/google/caja/lang/css/css21-whitelist.json View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 8 months ago (2013-07-03 10:31:01 UTC) #1
MikeSamuel
LGTM https://codereview.appspot.com/10830045/diff/1/src/com/google/caja/lang/css/CssPropertyPatterns.java File src/com/google/caja/lang/css/CssPropertyPatterns.java (right): https://codereview.appspot.com/10830045/diff/1/src/com/google/caja/lang/css/CssPropertyPatterns.java#newcode432 src/com/google/caja/lang/css/CssPropertyPatterns.java:432: // TODO(felix8a): why do this when standard-color doesn't ...
12 years, 8 months ago (2013-07-03 19:25:38 UTC) #2
felix8a
12 years, 8 months ago (2013-07-03 19:45:05 UTC) #3
@r5473
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b