Issue 10804043: Drop samples that would be better served being in the docs.

Issue 10804043: Drop samples that would be better served being in the docs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by jcgregorio_google

Modified:
11 years, 3 months ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Drop samples that would be better served being in the docs.

Patch Set 2 : drop less #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -315 lines)			Patch
R	samples/keyring/README	View	1 chunk	+0 lines, -4 lines	0 comments	Download
R	samples/keyring/client_secrets.json	View	1 chunk	+0 lines, -9 lines	0 comments	Download
R	samples/keyring/plus.py	View	1 chunk	+0 lines, -139 lines	0 comments	Download
R	samples/threadqueue/README	View	1 chunk	+0 lines, -4 lines	0 comments	Download
R	samples/threadqueue/main.py	View	1 chunk	+0 lines, -159 lines	0 comments	Download

Let's track those issue in the tracker and not in a CL: https://code.google.com/p/google-api-python-client/issues/detail?id=287 https://code.google.com/p/google-api-python-client/issues/detail?id=288 On ...

11 years, 3 months ago (2013-07-01 21:20:06 UTC) #7

Let's track those issue in the tracker and not in a CL:

  https://code.google.com/p/google-api-python-client/issues/detail?id=287
  https://code.google.com/p/google-api-python-client/issues/detail?id=288



On Mon, Jul 1, 2013 at 5:14 PM, Danny Hermes <dhermes@google.com> wrote:

> Nope. I'm not opposed to removing our samples footprint, but wanted to
> have clear actions to take.
>
> For example, I'm not opposed to moving the tasks sample to
> https://github.com/GoogleCloudPlatform and having the App Engine team
> maintain it.
>
> Unfortunately, this isn't a great week to have these discussions as most
> people are out on vacation.
>
>
> On Mon, Jul 1, 2013 at 2:07 PM, Joe Gregorio <jcgregorio@google.com>wrote:
>
>> Is that an LGTM?
>>
>>
>> On Mon, Jul 1, 2013 at 4:54 PM, Danny Hermes <dhermes@google.com> wrote:
>>
>>> Great. Shall we consult with the storage folks about their sample? As
>>> for the tasks sample, it was more a way to introduce GAE users to Discovery
>>> bases APIs.
>>>
>>>
>>> On Sun, Jun 30, 2013 at 9:24 PM, <jcgregorio@google.com> wrote:
>>>
>>>> On 2013/06/30 17:43:25, dhermes wrote:
>>>>
>>>>> Do any of these exist in the docs yet? Have you contacted the owners?
>>>>>
>>>>
>>>>  As far as I know, the full extent of the Tasks API sample is on
>>>>>
>>>>
>>>> https://developers.google.com/**appengine/articles/python/**
>>>>
getting_started_with_tasks_api<https://developers.google.com/appengine/articles/python/getting_started_with_tasks_api>
>>>>
>>>>> but the page also links to
>>>>>
>>>>
>>>> https://code.google.com/p/**google-api-python-client/**
>>>>
source/browse/#hg%252Fsamples%**252Ftasks_appengine<https://code.google.com/p/google-api-python-client/source/browse/#hg%252Fsamples%252Ftasks_appengine>
>>>>
>>>>
>>>>  As for the others, it's unclear.
>>>>>
>>>>
>>>>  For the record, I'm all for reducing the number of samples with no
>>>>>
>>>> owners, but
>>>>
>>>>> want to make sure we do it right.
>>>>>
>>>>
>>>> Leaving storage and tasks samples in place, still dropping
>>>> keyring and threadqueue samples, as I wrote those. PTAL.
>>>>
>>>> As for docs, keyring has already been added:
>>>>
>>>>
>>>> https://developers.google.com/**api-client-library/python/**
>>>>
guide/aaa_oauth#keyring_**storage<https://developers.google.com/api-client-library/python/guide/aaa_oauth#keyring_storage>
>>>>
>>>> I will pull together a separate CL to update:
>>>>
>>>>
>>>> https://developers.google.com/**api-client-library/python/**
>>>>
guide/thread_safety<https://developers.google.com/api-client-library/python/guide/thread_safety>
>>>>
>>>>
>>>>
https://codereview.appspot.**com/10804043/<https://codereview.appspot.com/108...
>>>>
>>>
>>>
>>>
>>> --
>>> Danny Hermes
>>> Developer Programs Engineer
>>>
>>
>>
>
>
> --
> Danny Hermes
> Developer Programs Engineer
>

dhermes

SGTM and LGTM On Mon, Jul 1, 2013 at 2:19 PM, Joe Gregorio <jcgregorio@google.com> wrote: ...

11 years, 3 months ago (2013-07-01 21:23:33 UTC) #8

SGTM and LGTM


On Mon, Jul 1, 2013 at 2:19 PM, Joe Gregorio <jcgregorio@google.com> wrote:

> Let's track those issue in the tracker and not in a CL:
>
>   https://code.google.com/p/google-api-python-client/issues/detail?id=287
>   https://code.google.com/p/google-api-python-client/issues/detail?id=288
>
>
>
> On Mon, Jul 1, 2013 at 5:14 PM, Danny Hermes <dhermes@google.com> wrote:
>
>> Nope. I'm not opposed to removing our samples footprint, but wanted to
>> have clear actions to take.
>>
>> For example, I'm not opposed to moving the tasks sample to
>> https://github.com/GoogleCloudPlatform and having the App Engine team
>> maintain it.
>>
>> Unfortunately, this isn't a great week to have these discussions as most
>> people are out on vacation.
>>
>>
>> On Mon, Jul 1, 2013 at 2:07 PM, Joe Gregorio <jcgregorio@google.com>wrote:
>>
>>> Is that an LGTM?
>>>
>>>
>>> On Mon, Jul 1, 2013 at 4:54 PM, Danny Hermes <dhermes@google.com> wrote:
>>>
>>>> Great. Shall we consult with the storage folks about their sample? As
>>>> for the tasks sample, it was more a way to introduce GAE users to
Discovery
>>>> bases APIs.
>>>>
>>>>
>>>> On Sun, Jun 30, 2013 at 9:24 PM, <jcgregorio@google.com> wrote:
>>>>
>>>>> On 2013/06/30 17:43:25, dhermes wrote:
>>>>>
>>>>>> Do any of these exist in the docs yet? Have you contacted the owners?
>>>>>>
>>>>>
>>>>>  As far as I know, the full extent of the Tasks API sample is on
>>>>>>
>>>>>
>>>>> https://developers.google.com/**appengine/articles/python/**
>>>>>
getting_started_with_tasks_api<https://developers.google.com/appengine/articles/python/getting_started_with_tasks_api>
>>>>>
>>>>>> but the page also links to
>>>>>>
>>>>>
>>>>> https://code.google.com/p/**google-api-python-client/**
>>>>>
source/browse/#hg%252Fsamples%**252Ftasks_appengine<https://code.google.com/p/google-api-python-client/source/browse/#hg%252Fsamples%252Ftasks_appengine>
>>>>>
>>>>>
>>>>>  As for the others, it's unclear.
>>>>>>
>>>>>
>>>>>  For the record, I'm all for reducing the number of samples with no
>>>>>>
>>>>> owners, but
>>>>>
>>>>>> want to make sure we do it right.
>>>>>>
>>>>>
>>>>> Leaving storage and tasks samples in place, still dropping
>>>>> keyring and threadqueue samples, as I wrote those. PTAL.
>>>>>
>>>>> As for docs, keyring has already been added:
>>>>>
>>>>>
>>>>> https://developers.google.com/**api-client-library/python/**
>>>>>
guide/aaa_oauth#keyring_**storage<https://developers.google.com/api-client-library/python/guide/aaa_oauth#keyring_storage>
>>>>>
>>>>> I will pull together a separate CL to update:
>>>>>
>>>>>
>>>>> https://developers.google.com/**api-client-library/python/**
>>>>>
guide/thread_safety<https://developers.google.com/api-client-library/python/guide/thread_safety>
>>>>>
>>>>>
>>>>>
https://codereview.appspot.**com/10804043/<https://codereview.appspot.com/108...
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Danny Hermes
>>>> Developer Programs Engineer
>>>>
>>>
>>>
>>
>>
>> --
>> Danny Hermes
>> Developer Programs Engineer
>>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "Google API Python Client" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-api-python-client+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>



-- 
Danny Hermes
Developer Programs Engineer

jcgregorio_google

11 years, 3 months ago (2013-07-02 16:43:29 UTC) #9

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=7b2931512e...

Expand All Messages | Collapse All Messages