Issue 10802043: coordinate blogger and audit samples updates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10802043: coordinate blogger and audit samples updates (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by jcgregorio_google

Modified:
12 years ago

Reviewers:
jcgregorio_google, dhermes

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Update coordinate, blogger, and audit samples.

Patch Set 2 : spacin #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1319 lines)			Patch
M	samples/audit/audit.py	View		3 chunks	+9 lines, -71 lines	0 comments	Download
M	samples/blogger/blogger.py	View		1 chunk	+16 lines, -76 lines	0 comments	Download
M	samples/coordinate/coordinate.py	View	1	3 chunks	+12 lines, -80 lines	0 comments	Download
R	samples/gan/README.txt	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
R	samples/gan/advertisers/advertisers.py	View	1	1 chunk	+0 lines, -189 lines	0 comments	Download
R	samples/gan/advertisers/advertisers_template.html	View	1	1 chunk	+0 lines, -85 lines	0 comments	Download
R	samples/gan/ccoffers/offers.py	View	1	1 chunk	+0 lines, -136 lines	0 comments	Download
R	samples/gan/ccoffers/offers_template.html	View	1	1 chunk	+0 lines, -117 lines	0 comments	Download
R	samples/gan/client_secrets.json	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
R	samples/gan/events/events.py	View	1	1 chunk	+0 lines, -185 lines	0 comments	Download
R	samples/gan/events/events_template.html	View	1	1 chunk	+0 lines, -106 lines	0 comments	Download
R	samples/gan/publishers/publishers.py	View	1	1 chunk	+0 lines, -188 lines	0 comments	Download
R	samples/gan/publishers/publishers_template.html	View	1	1 chunk	+0 lines, -73 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dhermes

LGTM (fix the indent though) https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate.py File samples/coordinate/coordinate.py (right): https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate.py#newcode51 samples/coordinate/coordinate.py:51: help='Coordinate Team ID') Indent ...

12 years ago (2013-06-30 17:46:33 UTC) #2

jcgregorio_google

https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate.py File samples/coordinate/coordinate.py (right): https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate.py#newcode51 samples/coordinate/coordinate.py:51: help='Coordinate Team ID') On 2013/06/30 17:46:33, dhermes wrote: > ...

12 years ago (2013-07-01 03:21:59 UTC) #3

jcgregorio_google

12 years ago (2013-07-01 03:22:22 UTC) #4

On 2013/07/01 03:21:59, jcgregorio_google wrote:
>
https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate.py
> File samples/coordinate/coordinate.py (right):
> 
>
https://codereview.appspot.com/10802043/diff/1/samples/coordinate/coordinate....
> samples/coordinate/coordinate.py:51: help='Coordinate Team ID')
> On 2013/06/30 17:46:33, dhermes wrote:
> > Indent not lined up.
> 
> Done.

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=a146c0ae0e...

Expand All Messages | Collapse All Messages