Improved the index gui section in the basic theme and added smiley support

Improved the index gui section in the basic theme and added smiley support

[Thomas.J.Waldmann, 2014-06-14 18:24:16]

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:313: background-color:
#428bca;
hardcoded colour

how is that compatible with bootstrap themes?

shouldn't colours be taken from some theme palette (or at least be based on
them)?

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:345: text-transform:
capitalize;
why?

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:350: text-transform:
capitalize;
why?

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:390: background: transparent
url("../img/moin-checkbox-off.png") no-repeat;
ehrm, doesn't bootstrap have something pretty for checkboxes that doesn't need
an image from us?

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:399: background-image:
url("../img/moin-checkbox-on.png");
same here

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:433: content:
url("../img/moin-parent.png");
same here

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:672: 
somehow I have a vague feeling that we add way to much own css and icons/images
instead of reusing good default styles that might be present in bootstrap.

[ajgupta93, 2014-06-26 11:50:27]

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/108020043/diff/1/MoinMoin/themes/basic/static/...
MoinMoin/themes/basic/static/custom-less/basic.less:313: background-color:
#428bca;
On 2014/06/14 18:24:16, Thomas.J.Waldmann wrote:
> hardcoded colour
> 
> how is that compatible with bootstrap themes?
> 
> shouldn't colours be taken from some theme palette (or at least be based on
> them)?
This color is picked from a bootstrap element already present in the theme.

[ajgupta93, 2014-06-26 12:14:37]

Screenshots for patchset 2 -
http://picpaste.com/pics/index1-da8qoGxo.1403784830.png
http://picpaste.com/pics/index2-Rh2Ubl7Q.1403784862.png

[RogerHaase, 2014-06-26 15:34:37]

works well (per my light testing).

You could help out your reviewers by anticipating reviewer's questions and
adding comments to the cr

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
File MoinMoin/static/js/index_action.js (left):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
MoinMoin/static/js/index_action.js:138: // also executed via .click call when
user clicks on an action (new, download, delete, destroy)
was this removed because it is untrue, poorly worded, or moin code has too many
comments?

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
File MoinMoin/static/js/index_action.js (right):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
MoinMoin/static/js/index_action.js:280: $(this >
"input[type='checkbox']").prop('checked', !$(this >
"input[type='checkbox']").is(':checked'));
what does this do?

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
MoinMoin/themes/basic/static/custom-less/basic.less:647: 
where did all this come from?  a comment at the top or bottom may help future
developers

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/stylus/main.styl (left):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/stylus/main.styl:831: background-image
url("../img/moin-checkbox-on.png")
adding some comments to cr (not source) as to why this is deleted would help
reviewers

[ajgupta93, 2014-06-26 15:53:14]

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
File MoinMoin/static/js/index_action.js (left):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
MoinMoin/static/js/index_action.js:138: // also executed via .click call when
user clicks on an action (new, download, delete, destroy)
On 2014/06/26 15:34:36, RogerHaase wrote:
> was this removed because it is untrue, poorly worded, or moin code has too
many
> comments?

Oh.. This is actually deleted mistakenly while making some changes. I'll put it
back.

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
File MoinMoin/static/js/index_action.js (right):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/static/js/index_...
MoinMoin/static/js/index_action.js:280: $(this >
"input[type='checkbox']").prop('checked', !$(this >
"input[type='checkbox']").is(':checked'));
On 2014/06/26 15:34:36, RogerHaase wrote:
> what does this do?

This is called when i click on the checkbox area. It sets or unsets the
"checked" property of the box according to the current value, basically toggling
the "checked" property on each click.

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
MoinMoin/themes/basic/static/custom-less/basic.less:647: 
On 2014/06/26 15:34:37, RogerHaase wrote:
> where did all this come from?  a comment at the top or bottom may help future
> developers

Actually i borrowed most of the stuff from other themes with only minor changes
at places.

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/modernize...
File MoinMoin/themes/modernized/static/css/stylus/main.styl (left):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/modernize...
MoinMoin/themes/modernized/static/css/stylus/main.styl:831: background-image
url("../img/moin-checkbox-on.png")
On 2014/06/26 15:34:37, RogerHaase wrote:
> adding some comments to cr (not source) as to why this is deleted would help
> reviewers

ThomasWaldmann advised that we should use things from bootstrap rather than
using images, as using custom images causes unnecessary stuff to be added which
is already present in bootstrap. So i removed these images and used normal
checkboxes instead. Also i made the checkboxes permanently visible instead of
making them visible on hover.

[RogerHaase, 2014-06-26 16:17:30]

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/108020043/diff/40001/MoinMoin/themes/basic/sta...
MoinMoin/themes/basic/static/custom-less/basic.less:647: 
On 2014/06/26 15:53:13, ajgupta93 wrote:
> On 2014/06/26 15:34:37, RogerHaase wrote:
> > where did all this come from?  a comment at the top or bottom may help
future
> > developers
> 
> Actually i borrowed most of the stuff from other themes with only minor
changes
> at places.

If this whole chunk only applies to Index page styling, Then add comments at top
and bottom saying that.