Issue 107860043: Fix a typo in src/ibusinputcontext.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107860043: Fix a typo in src/ibusinputcontext.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by fujiwara

Modified:
10 years ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix a typo in src/ibusinputcontext.c BUG=http://code.google.com/p/ibus/issues/detail?id=1717

Patch Set 2 : Updated with message #2. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
	M	src/ibusinputcontext.c	View	1	6 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

Lgtm with nits https://codereview.appspot.com/107860043/diff/1/src/ibusinputcontext.c File src/ibusinputcontext.c (right): https://codereview.appspot.com/107860043/diff/1/src/ibusinputcontext.c#newcode137 src/ibusinputcontext.c:137: * signal. If signal handler want ...

10 years ago (2014-06-09 11:41:57 UTC) #2

fujiwara

10 years ago (2014-06-10 02:32:48 UTC) #3

https://codereview.appspot.com/107860043/diff/1/src/ibusinputcontext.c
File src/ibusinputcontext.c (right):

https://codereview.appspot.com/107860043/diff/1/src/ibusinputcontext.c#newcod...
src/ibusinputcontext.c:137: *  signal. If signal handler want to keep the
object, the handler should
On 2014/06/09 11:41:56, Peng wrote:
> ->the signal handler wants

Done.

Expand All Messages | Collapse All Messages