Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159)

Issue 107710043: FSA Fix b/16139028 Part1: Close DirectoryStreams to avoid leaking resources. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Brett
Modified:
8 years, 1 month ago
Reviewers:
Brett Johnson, pjo, mifern
CC:
connector-cr_google.com
Visibility:
Public.

Description

This change closes the DirectoryStreams in FsAdaptor, as they were being leaked. Also closes a Windows HANDLE in a finally clause in WindowFileDelegate.getLastAccessTime to ensure it gets called.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M src/com/google/enterprise/adaptor/fs/FsAdaptor.java View 3 chunks +10 lines, -4 lines 0 comments Download
M src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java View 1 chunk +11 lines, -9 lines 1 comment Download

Messages

Total messages: 4
Brett
8 years, 1 month ago (2014-07-10 03:48:17 UTC) #1
mifern
https://codereview.appspot.com/107710043/diff/1/src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right): https://codereview.appspot.com/107710043/diff/1/src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java#newcode106 src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:106: kernel32.GetFileTime(handle, null, accessTime, null); This is not needed. The ...
8 years, 1 month ago (2014-07-10 15:55:19 UTC) #2
pjo
LGTM. Thank you
8 years, 1 month ago (2014-07-10 21:45:21 UTC) #3
Brett
8 years, 1 month ago (2014-07-10 23:06:57 UTC) #4
Committed 10 July 2014 to Filesystem Adaptor:

To https://code.google.com/p/plexi.fs/
   473e293..fe9d9c9  master -> master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b