Issue 107700043: ticket:10944: Add ByteBuffer support for conversion classes.

Issue 107700043: ticket:10944: Add ByteBuffer support for conversion classes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by roubert (google)

Modified:
10 years, 6 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk

Visibility:
Public.

More Reviews

Description

ticket:10944: Add ByteBuffer support for conversion classes. Updates UConverterDataReader, UConverterAlias and UConverterAliasDataReader. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/36039

Patch Set 1 #

Patch Set 2 : Remove @draft annotations not paired with @stable. #

Patch Set 3 : Delete unused code. #

Total comments: 6

Patch Set 4 : Code review. #

Patch Set 5 : Rebase. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -137 lines)			Patch
M	main/classes/charset/src/com/ibm/icu/charset/CharsetMBCS.java	View	1 2 3	3 chunks	+6 lines, -5 lines	0 comments	Download
M	main/classes/charset/src/com/ibm/icu/charset/UConverterAlias.java	View	1 2 3	4 chunks	+12 lines, -16 lines	0 comments	Download
M	main/classes/charset/src/com/ibm/icu/charset/UConverterAliasDataReader.java	View	1 2 3	3 chunks	+38 lines, -42 lines	0 comments	Download
M	main/classes/charset/src/com/ibm/icu/charset/UConverterDataReader.java	View	1 2 3	9 chunks	+63 lines, -74 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

https://codereview.appspot.com/107700043/diff/40001/main/classes/charset/src/com/ibm/icu/charset/UConverterAliasDataReader.java File main/classes/charset/src/com/ibm/icu/charset/UConverterAliasDataReader.java (right): https://codereview.appspot.com/107700043/diff/40001/main/classes/charset/src/com/ibm/icu/charset/UConverterAliasDataReader.java#newcode160 main/classes/charset/src/com/ibm/icu/charset/UConverterAliasDataReader.java:160: convList[i] = byteBuffer.getShort() & 0xffff; byteBuffer.getShort() & 0xffff --> ...

10 years, 6 months ago (2014-07-11 20:01:10 UTC) #2

roubert (google)

10 years, 6 months ago (2014-07-14 15:05:18 UTC) #3

roubert (google)

10 years, 6 months ago (2014-07-15 21:01:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r36039 (presubmit successful).

Expand All Messages | Collapse All Messages