Expand support for CSS attribute selectors

https://code.google.com/p/google-caja/issues/detail?id=1733

(1) expands the subset of the CSS attribute selector supported by
    sanitizeSelector to include attributes mixed with ID and class selectors,
    to recognize both quoted and unquoted attribute values, and to recognize
    case insensitivity flags.
(2) fleshes out the set of CSS attribute selector transforms that we can
    perform and adds tests for various kinds of these.
(3) fixes a bug in jsUnitCore which broke assertArrayEquals which is not
    widely used outside the CSS sanitizer tests.

Submitted at r5464

[felix8a, 2013-07-01 15:42:26]

lgtm

https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
File src/com/google/caja/plugin/sanitizecss.js (right):

https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
src/com/google/caja/plugin/sanitizecss.js:324: && (inBrackets ||
COMBINATOR[selectors[i-1]] == COMBINATOR
== should be ===

https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
src/com/google/caja/plugin/sanitizecss.js:325: || COMBINATOR[selectors[i+1]] ==
COMBINATOR))
same

https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
src/com/google/caja/plugin/sanitizecss.js:359: if (COMBINATOR[tok] == COMBINATOR
|| tok === ' ') {
same

[MikeSamuel, 2013-07-01 15:53:00]

https://code.google.com/p/google-caja/issues/detail?id=1733

(1) expands the subset of the CSS attribute selector supported by
    sanitizeSelector to include attributes mixed with ID and class selectors,
    to recognize both quoted and unquoted attribute values, and to recognize
    case insensitivity flags.
(2) fleshes out the set of CSS attribute selector transforms that we can
    perform and adds tests for various kinds of these.
(3) fixes a bug in jsUnitCore which broke assertArrayEquals which is not
    widely used outside the CSS sanitizer tests.

[MikeSamuel, 2013-07-01 15:53:18]

done x 3

2013/7/1  <felix8a@gmail.com>:
> lgtm
>
>
>
https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
> File src/com/google/caja/plugin/sanitizecss.js (right):
>
>
https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
> src/com/google/caja/plugin/sanitizecss.js:324: && (inBrackets ||
> COMBINATOR[selectors[i-1]] == COMBINATOR
> == should be ===
>
>
https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
> src/com/google/caja/plugin/sanitizecss.js:325: ||
> COMBINATOR[selectors[i+1]] == COMBINATOR))
> same
>
>
https://codereview.appspot.com/10763044/diff/1/src/com/google/caja/plugin/san...
> src/com/google/caja/plugin/sanitizecss.js:359: if (COMBINATOR[tok] ==
> COMBINATOR || tok === ' ') {
> same
>
> https://codereview.appspot.com/10763044/

[MikeSamuel, 2013-07-01 16:15:22]

https://code.google.com/p/google-caja/issues/detail?id=1733

(1) expands the subset of the CSS attribute selector supported by
    sanitizeSelector to include attributes mixed with ID and class selectors,
    to recognize both quoted and unquoted attribute values, and to recognize
    case insensitivity flags.
(2) fleshes out the set of CSS attribute selector transforms that we can
    perform and adds tests for various kinds of these.
(3) fixes a bug in jsUnitCore which broke assertArrayEquals which is not
    widely used outside the CSS sanitizer tests.

[felix8a, 2013-07-01 16:52:14]

lgtm