Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 10761046: trying to diagnose localserver port flakiness (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by felix8a
Modified:
12 years, 8 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

sometimes a browser test starts a local http server, then fails to get the port number for that server, and the symptom is the browser test tries to load http://localhost:-1/... which fails since that isn't a valid URL. the getPort failure is happening after the localserver is started successfully (because I have a log message that the server has started, and the timestamp is shortly before the message that we're about to load the invalid URL.) I don't have any good theories why this is happening. getting port=-1 is possible if the local server has stopped, but that isn't something we're doing, there aren't any messages that look like the server is stopping abnormally, and I can't think of any way for that to happen. lacking any good theories, I'm adding some code that might help diagnose the problem.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tests/com/google/caja/util/LocalServer.java View 2 chunks +10 lines, -1 line 2 comments Download

Messages

Total messages: 3
felix8a
12 years, 8 months ago (2013-07-02 06:23:42 UTC) #1
kpreid2
LGTM https://codereview.appspot.com/10761046/diff/1/tests/com/google/caja/util/LocalServer.java File tests/com/google/caja/util/LocalServer.java (right): https://codereview.appspot.com/10761046/diff/1/tests/com/google/caja/util/LocalServer.java#newcode55 tests/com/google/caja/util/LocalServer.java:55: "connectors.length=" + server.getConnectors().length); Does a connector object have ...
12 years, 8 months ago (2013-07-02 16:49:19 UTC) #2
felix8a
12 years, 8 months ago (2013-07-02 19:03:26 UTC) #3
@r5469

https://codereview.appspot.com/10761046/diff/1/tests/com/google/caja/util/Loc...
File tests/com/google/caja/util/LocalServer.java (right):

https://codereview.appspot.com/10761046/diff/1/tests/com/google/caja/util/Loc...
tests/com/google/caja/util/LocalServer.java:55: "connectors.length=" +
server.getConnectors().length);
On 2013/07/02 16:49:19, kpreid2 wrote:
> Does a connector object have a useful toString? If so, perhaps include it.
Also
> maybe some whitespace for readability and wrappability.

yeah, ok. I was thinking connectors is unlikely to be the issue, but since I
don't have any good theories at all, might as well dump that too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b