Issue 10751043: environs/config: relaxed validation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10751043: environs/config: relaxed validation

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by fwereade

Modified:
10 years, 9 months ago

Reviewers:
mue, dimitern, mp+172076

Visibility:
Public.

Description

environs/config: relaxed validation To allow us to change environment configuration compatibly, unknown keys are preserved (but we log a warning when we encounter them). https://code.launchpad.net/~fwereade/juju-core/environ-config-laxity/+merge/172076 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -114 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/azure/config.go	View	2 chunks	+21 lines, -23 lines	0 comments	Download
M	environs/azure/config_test.go	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	environs/config/config_test.go	View	2 chunks	+48 lines, -0 lines	0 comments	Download
M	environs/config_test.go	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	environs/dummy/environs.go	View	2 chunks	+11 lines, -14 lines	0 comments	Download
M	environs/ec2/config.go	View	2 chunks	+18 lines, -19 lines	0 comments	Download
M	environs/ec2/config_test.go	View	3 chunks	+20 lines, -0 lines	0 comments	Download
M	environs/maas/config.go	View	2 chunks	+9 lines, -11 lines	0 comments	Download
M	environs/maas/config_test.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	environs/openstack/config.go	View	2 chunks	+38 lines, -40 lines	0 comments	Download
M	environs/openstack/config_test.go	View	3 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM, nice cleanup!

Expand All Messages | Collapse All Messages