Issue 107490043: Chromium branch changes to rename ndb key fields to have _key in names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107490043: Chromium branch changes to rename ndb key fields to have _key in names (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by jrobbins (chromium)

Modified:
5 days, 2 hours ago

Reviewers:
jrobbins (corp), iannucci

Visibility:
Public.

More Reviews

Description

Chromium branch changes to rename ndb key fields to have _key in names

Patch Set 3 : Removed temporary logging and fixed one more reference #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
M	codereview/decorators.py	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	codereview/decorators_chromium.py	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	codereview/models.py	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	codereview/revert_patchset.py	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	codereview/views.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	templates/patchset.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jrobbins (corp)

This is the chromium branch part of renaming ndb KeyProperty fields to end with "_key".

11 years ago (2014-07-02 22:59:40 UTC) #1

iannucci

lgtm % typo https://codereview.appspot.com/107490043/diff/1/codereview/models.py File codereview/models.py (right): https://codereview.appspot.com/107490043/diff/1/codereview/models.py#newcode919 codereview/models.py:919: original_patched_content = self.patched_conten_keyt.get() typo. If only ...

11 years ago (2014-07-03 18:53:01 UTC) #2

jrobbins (corp)

10 years, 12 months ago (2014-07-07 23:39:21 UTC) #3

This was committed as
https://code.google.com/p/rietveld/source/detail?r=d07f5eafedd9ef893fec51ddf7...

https://codereview.appspot.com/107490043/diff/1/codereview/models.py
File codereview/models.py (right):

https://codereview.appspot.com/107490043/diff/1/codereview/models.py#newcode919
codereview/models.py:919: original_patched_content =
self.patched_conten_keyt.get()
On 2014/07/03 18:53:01, iannucci wrote:
> typo. If only there were tests...

Fixed.  And, I also found and fixed another error.

Expand All Messages | Collapse All Messages