Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(467)

Issue 10746046: Don't not repair PUSH_IGNORES_FROZEN. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kpreid2
Modified:
12 years, 7 months ago
Reviewers:
MarkM, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

We have no reason not to run the repair for PUSH_IGNORES_FROZEN rather than failing; it was kept disabled in r5442 only due to sloppy thinking about preserving existing behavior. Makes ES5 mode able to run on Chrome versions suffering from <https://code.google.com/p/v8/issues/detail?id=2711>. Addresses <https://code.google.com/p/google-caja/issues/detail?id=1808>. @r5491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/com/google/caja/plugin/caja.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
kpreid2
12 years, 8 months ago (2013-07-12 00:19:23 UTC) #1
MarkM
LGTM
12 years, 8 months ago (2013-07-12 01:29:31 UTC) #2
ihab.awad
12 years, 7 months ago (2013-07-15 15:08:44 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b