Issue 1073041: code review 1073041: Add _cgo_export.[ch] targets so that make knows how they are

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1073041: code review 1073041: Add _cgo_export.[ch] targets so that make knows how they are (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by iant

Modified:
14 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Add _cgo_export.[ch] targets so that make knows how they are built. Note that they are only built if a //export comment appears, so other targets should only use them if there is such a comment. Fixes issue 723.

Patch Set 1 #

Patch Set 2 : code review 1073041: Add _cgo_export.[ch] targets so that make knows how they are #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/Make.pkg	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-05-03 17:44:53 UTC) #1

iant

14 years, 11 months ago (2010-05-03 18:07:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c529b59ee1fb ***

Add _cgo_export.[ch] targets so that make knows how they are
built.  Note that they are only built if a //export comment
appears, so other targets should only use them if there is
such a comment.

Fixes issue 723.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1073041

Expand All Messages | Collapse All Messages