Issue 107061: Fix @Overrides in the collections utility classes that break jdk1.5 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107061: Fix @Overrides in the collections utility classes that break jdk1.5 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by MikeSamuel

Modified:
16 years, 6 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Removed @Override clauses on methods specified in interfaces. Also changed Multimaps to allow easy cloning. Submitted @3694

Patch Set 1 #

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -64 lines)			Patch
M	src/com/google/caja/util/Lists.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/util/Multimap.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/util/Multimaps.java	View	11 chunks	+58 lines, -42 lines	0 comments	Download
M	tests/com/google/caja/util/CollectionsTest.java	View	3 chunks	+33 lines, -22 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MarkM

16 years, 7 months ago (2009-09-02 20:56:51 UTC) #2

It's a shame that the new functionality has such a high price in
understanability of the code, due to greater indirection and higher-order-ness.
But I don't see a better way.

LGTM.

Expand All Messages | Collapse All Messages