Issue 10698043: Update charm to reference itself as reviewed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10698043: Update charm to reference itself as reviewed

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by curtis

Modified:
10 years, 10 months ago

Reviewers:
bac, mp+171877

Visibility:
Public.

Description

Update charm to reference itself as reviewed Update the charm documentation to show that the reviewed charm is owned by ~juju-gui-charmers and its charm store URL is cs:precise/juju-gui. https://code.launchpad.net/~sinzui/charms/precise/juju-gui/update-readme/+merge/171877 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update charm to reference itself as reviewed #

Patch Set 3 : Update charm to reference itself as reviewed #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	README.md	View		4 chunks	+6 lines, -6 lines	0 comments	Download
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM if you revert the changes in HACKING. Thanks. https://codereview.appspot.com/10698043/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/10698043/diff/1/HACKING.md#newcode24 HACKING.md:24: ...

10 years, 10 months ago (2013-06-27 18:19:40 UTC) #2

curtis

I agree. It was not my intent to steer contributors to hack on non-devel. -- ...

10 years, 10 months ago (2013-06-27 18:33:58 UTC) #3

Please take a look.

Expand All Messages | Collapse All Messages