Subscriptions cleanup and update

Subscriptions cleanup and update

[Thomas.J.Waldmann, 2013-07-14 08:10:21]

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/apps/frontend/view...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:840: abort(403)
these kind of changes look like a bugfix and not directly related to your work.
should be a separate cs.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/constants/keys.py
File MoinMoin/constants/keys.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/constants/keys.py#...
MoinMoin/constants/keys.py:72: SUBSCRIPTION_PATTERNS = u"subscription_patterns"
hmm, do we want all 3 in the index?

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
File MoinMoin/script/migration/moin19/import19.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:641: subscription_patterns meta
fix docstring to match current implementation

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:649: # a subscription_id with a
NAME keyword
yeah, that's definitely desirable for performance reasons

make a TODO out of that.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:650: wikiname, namespace, pagename
= split_interwiki(subscribed_item)
you are calling the moin2 split_interwiki with data from 1.9.

check whether it does the right thing.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:651:
subscriptions.append("{0}:{1}:{2}".format(NAMERE, namespace, pagename))
you lost the wikiname?

[ana.balica, 2013-07-14 08:29:28]

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/constants/keys.py
File MoinMoin/constants/keys.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/constants/keys.py#...
MoinMoin/constants/keys.py:72: SUBSCRIPTION_PATTERNS = u"subscription_patterns"
On 2013/07/14 08:10:21, Thomas.J.Waldmann wrote:
> hmm, do we want all 3 in the index?

2 in index (SUBSCRIPTION_IDS and SUBSCRIPTION_PATTERNS) and one in user profile
meta (SUBSCRIPTIONS).
The first 2 are not added to the USEROBJ_ATTRS, just SUBSCRIPTIONS.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
File MoinMoin/script/migration/moin19/import19.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:650: wikiname, namespace, pagename
= split_interwiki(subscribed_item)
On 2013/07/14 08:10:21, Thomas.J.Waldmann wrote:
> you are calling the moin2 split_interwiki with data from 1.9.
> 
> check whether it does the right thing.

Now at the second glance I am not sure, I am going to double check the
subscribed_pages format from moin19 and the splitting.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:651:
subscriptions.append("{0}:{1}:{2}".format(NAMERE, namespace, pagename))
On 2013/07/14 08:10:21, Thomas.J.Waldmann wrote:
> you lost the wikiname?

Hmm.. of what use can be the wikiname for subscriptions meta?

[ana.balica, 2013-07-19 14:23:03]

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/apps/frontend/view...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:840: abort(403)
On 2013/07/14 08:10:21, Thomas.J.Waldmann wrote:
> these kind of changes look like a bugfix and not directly related to your
work.
> should be a separate cs.

ok, will commit them separately.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
File MoinMoin/script/migration/moin19/import19.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:650: wikiname, namespace, pagename
= split_interwiki(subscribed_item)
In moin1.9 a subscription was made of:
<interwiki>:<pagename>
where interwiki is a config variable. 
The only part that can be useful to moin2.0 subscriptions is the pagename.
Is there some way to get the namespace? If not, should we set all the
subscriptions in the default namespace or for each available namespace?

[Thomas.J.Waldmann, 2013-07-20 12:09:04]

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
File MoinMoin/script/migration/moin19/import19.py (right):

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:650: wikiname, namespace, pagename
= split_interwiki(subscribed_item)
1.9 did not have namespace, so yes, it is all the default namespace.

BUT, we will need that interwiki component (which is somehow similar to a
namespace, but on a higher level).

I suggest for now you add a "# TODO support interwiki wikiname" and fix it in a
separate changeset.

https://codereview.appspot.com/10693045/diff/3001/MoinMoin/script/migration/m...
MoinMoin/script/migration/moin19/import19.py:651:
subscriptions.append("{0}:{1}:{2}".format(NAMERE, namespace, pagename))

> Hmm.. of what use can be the wikiname for subscriptions meta?


e.g. multiple wiki installations (with different interwikinames) could share the
same user backend (this was a quite usual scenario in 1.9).

will also need some thinking for the item matching.