Issue 106920043: remove computed properties code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106920043: remove computed properties code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by rafaelw

Modified:
9 years, 10 months ago

Reviewers:
arv, John Messerly

Base URL:
git@github.com:Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

remove computed properties code This patch removes support for computed properties which had already gotten a little weird and was continuing to be more & more polymer-specific. The code has been moved to polymer proper. R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/c701be1

Patch Set 1 #

Patch Set 2 : foo #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -464 lines)			Patch
M	src/observe.js	View	2 chunks	+1 line, -93 lines	0 comments	Download
M	tests/index.html	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	tests/test.js	View	1 chunk	+0 lines, -181 lines	0 comments	Download
D	tests/test_array_reduction.js	View	1 chunk	+0 lines, -82 lines	0 comments	Download
D	util/array_reduction.js	View	1 chunk	+0 lines, -105 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafaelw

Also, I just went ahead and removed ArrayReduction since it current has no actual uses ...

9 years, 10 months ago (2014-06-09 23:55:11 UTC) #1

rafaelw

Committed patchset #2 manually as rc701be1 (presubmit successful).

9 years, 10 months ago (2014-06-09 23:55:20 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages