Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(710)

Issue 10684044: state/apiserver/facades: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by rog
Modified:
10 years, 10 months ago
Reviewers:
mp+171870
Visibility:
Public.

Description

state/apiserver/facades: new package This is a spike branch with no new tests (although all current tests pass, with the exception of permSuite.TestOperationPerm which fails because the error messages have changed) You may want to split it up into smaller steps. The new package holds the "glue" pieces that put the various API component pieces together. I decided that a single package worked well as there are actually pieces common to all of them and the actual code is very short. The universal root API type has now gone; the API chooses an appropriate type to use for the given client, as I described in the meeting. https://code.launchpad.net/~rogpeppe/juju-core/333-apiserver-choose-api/+merge/171870 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver/facades: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -293 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/apiclient.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/admin.go View 2 chunks +38 lines, -2 lines 0 comments Download
M state/apiserver/apiserver.go View 1 chunk +2 lines, -2 lines 0 comments Download
A state/apiserver/facades/machine.go View 1 chunk +76 lines, -0 lines 0 comments Download
M state/apiserver/machineagent/agent.go View 3 chunks +31 lines, -15 lines 0 comments Download
M state/apiserver/machineagent/agent_test.go View 2 chunks +6 lines, -15 lines 0 comments Download
A state/apiserver/machineagent/common_test.go View 1 chunk +45 lines, -0 lines 0 comments Download
M state/apiserver/machiner/common_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/machiner/machiner.go View 9 chunks +42 lines, -26 lines 0 comments Download
M state/apiserver/machiner/machiner_test.go View 5 chunks +5 lines, -14 lines 0 comments Download
D state/apiserver/root.go View 1 chunk +0 lines, -189 lines 0 comments Download
M state/apiserver/watchers/watcher.go View 5 chunks +127 lines, -28 lines 0 comments Download
A state/apiserver/watchers/watchers_test.go View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1
rog
10 years, 10 months ago (2013-06-27 17:46:20 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b