Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1179)

Issue 106830043: Return non-floating ref from IBusConfigGConf::get_value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by fujiwara
Modified:
10 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara, cfergeau_redhat.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Return non-floating ref from IBusConfigGConf::get_value Both IBusConfigDConf::get_value and IBusConfigMemconf::get_value return a non-floating reference, so we need to be consistent in the gconf backend and also return a non-floating reference. BUG=http://code.google.com/p/ibus/issues/detail?id=1712

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M conf/gconf/config.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
fujiwara
10 years, 5 months ago (2014-06-04 08:05:32 UTC) #1
Peng
10 years, 5 months ago (2014-06-05 14:15:27 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b