Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 10663: Regex fix to ${} detection

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 2 months ago by levik
Modified:
11 years, 2 months ago
Reviewers:
shindig-dev, Evan Gilbert
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Fixing regular expression for variable substitutions to allow dollar characters before the ${}. Adding unit tests to check various variable substitution scenarios. Capitalized regex constant names. JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
features/opensocial-templates View 0 chunks +-1 lines, --1 lines 0 comments Download
features/opensocial-templates/base.js View 2 chunks +2 lines, -4 lines 0 comments Download
features/opensocial-templates/compiler.js View 8 chunks +9 lines, -6 lines 1 comment Download
features/opensocial-templates/compiler_test.js View 1 chunk +18 lines, -0 lines 0 comments Download
features/opensocial-templates/data.js View 1 chunk +1 line, -1 line 0 comments Download
features/opensocial-templates/data_test.js View 1 chunk +1 line, -1 line 0 comments Download
features/opensocial-templates/template_test.js View 1 chunk +0 lines, -1 line 0 comments Download
java/server/src/test/resources/endtoend/opensocial-templates/compiler_test.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2
levik
17 years, 2 months ago (2008-12-15 22:02:44 UTC) #1
Evan Gilbert
17 years, 2 months ago (2008-12-16 21:50:45 UTC) #2
http://codereview.appspot.com/10663/diff/1/9
File features/opensocial-templates/compiler.js (right):

http://codereview.appspot.com/10663/diff/1/9#newcode176
Line 176: 'Count': VAR_count,
Still think the comma will break IE.

I removed it - any reason it keeps showing up in CLs?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b