Issue 106610043: ticket:10944: Switch DictionaryData to use ByteBuffer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106610043: ticket:10944: Switch DictionaryData to use ByteBuffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by roubert (google)

Modified:
10 years, 5 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk

Visibility:
Public.

More Reviews

Description

ticket:10944: Switch DictionaryData to use ByteBuffer. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/36041

Patch Set 5 : Rebase. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	main/classes/core/src/com/ibm/icu/text/DictionaryData.java	View	1 2 3	4 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

https://codereview.appspot.com/106610043/diff/1/main/classes/core/src/com/ibm/icu/text/DictionaryData.java File main/classes/core/src/com/ibm/icu/text/DictionaryData.java (right): https://codereview.appspot.com/106610043/diff/1/main/classes/core/src/com/ibm/icu/text/DictionaryData.java#newcode53 main/classes/core/src/com/ibm/icu/text/DictionaryData.java:53: is.close(); redundant

10 years, 5 months ago (2014-07-11 20:12:43 UTC) #2

roubert (google)

10 years, 5 months ago (2014-07-14 15:06:02 UTC) #3

roubert (google)

10 years, 5 months ago (2014-07-15 21:14:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r36041 (presubmit successful).

Expand All Messages | Collapse All Messages