Issue 10658043: In ShaderExecutable, delete mFunction with delete[] instead of delete.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10658043: In ShaderExecutable, delete mFunction with delete[] instead of delete. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by apatrick1

Modified:
10 years, 10 months ago

Reviewers:
zhaoqin, Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

In ShaderExecutable, delete mFunction with delete[] instead of delete. BUG=chromium:253578 R=shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=0ee126c

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/libGLESv2/renderer/ShaderExecutable.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

apatrick1

Committed patchset #1 manually as r0ee126c (presubmit successful).

10 years, 10 months ago (2013-06-27 00:12:09 UTC) #3

zhaoqin

10 years, 10 months ago (2013-06-27 02:07:30 UTC) #4

Message was sent while issue was closed.

On 2013/06/27 00:12:09, apatrick1 wrote:
> Committed patchset #1 manually as r0ee126c (presubmit successful).

please updated the suppression file once the problem is fixed.

Expand All Messages | Collapse All Messages