Fix various bugs in API taming

Fixes the following bugs:

  https://code.google.com/p/google-caja/issues/detail?id=1766
  https://code.google.com/p/google-caja/issues/detail?id=1767
  https://code.google.com/p/google-caja/issues/detail?id=1775
  https://code.google.com/p/google-caja/issues/detail?id=1776
  https://code.google.com/p/google-caja/issues/detail?id=1777

Issue 1777 was "fixed" by simply realizing that whatever issue was causing
garbled data many, many CL's ago was no longer an issue.

[kpreid2, 2013-06-27 18:33:48]

https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/gue...
File src/com/google/caja/plugin/guest-manager.js (right):

https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/gue...
src/com/google/caja/plugin/guest-manager.js:90:
self.tame(self.markReadOnlyRecord(opts))])
This will fail if the same opts is passed more than once; don't mark things
without copying/wrapping them. Right?

[ihab.awad, 2013-06-27 20:26:20]

Fixes the following bugs:

  https://code.google.com/p/google-caja/issues/detail?id=1766
  https://code.google.com/p/google-caja/issues/detail?id=1767
  https://code.google.com/p/google-caja/issues/detail?id=1775
  https://code.google.com/p/google-caja/issues/detail?id=1776
  https://code.google.com/p/google-caja/issues/detail?id=1777

Issue 1777 was "fixed" by simply realizing that whatever issue was causing
garbled data many, many CL's ago was no longer an issue.

[ihab.awad, 2013-06-27 20:27:37]

https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/gue...
File src/com/google/caja/plugin/guest-manager.js (right):

https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/gue...
src/com/google/caja/plugin/guest-manager.js:90:
self.tame(self.markReadOnlyRecord(opts))])
On 2013/06/27 18:33:49, kpreid2 wrote:
> This will fail if the same opts is passed more than once; don't mark things
> without copying/wrapping them. Right?

Done.

[kpreid2, 2013-06-27 20:33:26]

https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/...
File src/com/google/caja/plugin/guest-manager.js (right):

https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/...
src/com/google/caja/plugin/guest-manager.js:68: if (o.hasOwnProperty(k)) {
Use Object.prototype.hasOwnProperty.call just for robustness.

https://codereview.appspot.com/10648043/diff/5001/tests/com/google/caja/plugi...
File tests/com/google/caja/plugin/test-index.js (right):

https://codereview.appspot.com/10648043/diff/5001/tests/com/google/caja/plugi...
tests/com/google/caja/plugin/test-index.js:116: loadCatalog('tests',
'apitaming-tests.json');
Please add
// TODO(kpreid): Refactor to avoid unnecessary latency and dependencies, perhaps
using Q.

[kpreid2, 2013-06-27 20:34:28]

Oh, forgot to say: LGTM

[ihab.awad, 2013-06-27 20:37:37]

Fixes the following bugs:

  https://code.google.com/p/google-caja/issues/detail?id=1766
  https://code.google.com/p/google-caja/issues/detail?id=1767
  https://code.google.com/p/google-caja/issues/detail?id=1775
  https://code.google.com/p/google-caja/issues/detail?id=1776
  https://code.google.com/p/google-caja/issues/detail?id=1777

Issue 1777 was "fixed" by simply realizing that whatever issue was causing
garbled data many, many CL's ago was no longer an issue.

[ihab.awad, 2013-06-27 20:38:57]

https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/...
File src/com/google/caja/plugin/guest-manager.js (right):

https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/...
src/com/google/caja/plugin/guest-manager.js:68: if (o.hasOwnProperty(k)) {
On 2013/06/27 20:33:26, kpreid2 wrote:
> Use Object.prototype.hasOwnProperty.call just for robustness.

Done.

https://codereview.appspot.com/10648043/diff/5001/tests/com/google/caja/plugi...
File tests/com/google/caja/plugin/test-index.js (right):

https://codereview.appspot.com/10648043/diff/5001/tests/com/google/caja/plugi...
tests/com/google/caja/plugin/test-index.js:116: loadCatalog('tests',
'apitaming-tests.json');
On 2013/06/27 20:33:26, kpreid2 wrote:
> Please add
> // TODO(kpreid): Refactor to avoid unnecessary latency and dependencies,
perhaps
> using Q.

Done.

[ihab.awad, 2013-06-27 20:48:49]

@5462