Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263)

Issue 10648043: Fix various bugs in API taming (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by ihab.awad
Modified:
12 years, 8 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes the following bugs: https://code.google.com/p/google-caja/issues/detail?id=1766 https://code.google.com/p/google-caja/issues/detail?id=1767 https://code.google.com/p/google-caja/issues/detail?id=1775 https://code.google.com/p/google-caja/issues/detail?id=1776 https://code.google.com/p/google-caja/issues/detail?id=1777 Issue 1777 was "fixed" by simply realizing that whatever issue was causing garbled data many, many CL's ago was no longer an issue.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix various bugs in API taming #

Total comments: 4

Patch Set 3 : Fix various bugs in API taming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -222 lines) Patch
M src/com/google/caja/apitaming/cajaTamingGoogleLoader.js View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/apitaming/google.visualization.policyFactory.js View 5 chunks +73 lines, -56 lines 0 comments Download
M src/com/google/caja/plugin/guest-manager.js View 1 2 3 chunks +38 lines, -2 lines 0 comments Download
M tests/com/google/caja/apitaming/visualization-list.json View 2 chunks +2 lines, -0 lines 0 comments Download
A tests/com/google/caja/apitaming/visualization/chart-range-filter.html View 1 chunk +111 lines, -0 lines 0 comments Download
A + tests/com/google/caja/apitaming/visualization/formatters-table.html View 3 chunks +7 lines, -7 lines 0 comments Download
M tests/com/google/caja/apitaming/visualization/table.html View 1 chunk +14 lines, -4 lines 0 comments Download
A + tests/com/google/caja/plugin/apitaming-tests.json View 1 chunk +29 lines, -151 lines 0 comments Download
M tests/com/google/caja/plugin/test-index.js View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9
ihab.awad
12 years, 8 months ago (2013-06-26 22:28:18 UTC) #1
kpreid2
https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/guest-manager.js File src/com/google/caja/plugin/guest-manager.js (right): https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/guest-manager.js#newcode90 src/com/google/caja/plugin/guest-manager.js:90: self.tame(self.markReadOnlyRecord(opts))]) This will fail if the same opts is ...
12 years, 8 months ago (2013-06-27 18:33:48 UTC) #2
ihab.awad
Fixes the following bugs: https://code.google.com/p/google-caja/issues/detail?id=1766 https://code.google.com/p/google-caja/issues/detail?id=1767 https://code.google.com/p/google-caja/issues/detail?id=1775 https://code.google.com/p/google-caja/issues/detail?id=1776 https://code.google.com/p/google-caja/issues/detail?id=1777 Issue 1777 was "fixed" by simply ...
12 years, 8 months ago (2013-06-27 20:26:20 UTC) #3
ihab.awad
https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/guest-manager.js File src/com/google/caja/plugin/guest-manager.js (right): https://codereview.appspot.com/10648043/diff/1/src/com/google/caja/plugin/guest-manager.js#newcode90 src/com/google/caja/plugin/guest-manager.js:90: self.tame(self.markReadOnlyRecord(opts))]) On 2013/06/27 18:33:49, kpreid2 wrote: > This will ...
12 years, 8 months ago (2013-06-27 20:27:37 UTC) #4
kpreid2
https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/guest-manager.js File src/com/google/caja/plugin/guest-manager.js (right): https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/guest-manager.js#newcode68 src/com/google/caja/plugin/guest-manager.js:68: if (o.hasOwnProperty(k)) { Use Object.prototype.hasOwnProperty.call just for robustness. https://codereview.appspot.com/10648043/diff/5001/tests/com/google/caja/plugin/test-index.js ...
12 years, 8 months ago (2013-06-27 20:33:26 UTC) #5
kpreid2
Oh, forgot to say: LGTM
12 years, 8 months ago (2013-06-27 20:34:28 UTC) #6
ihab.awad
Fixes the following bugs: https://code.google.com/p/google-caja/issues/detail?id=1766 https://code.google.com/p/google-caja/issues/detail?id=1767 https://code.google.com/p/google-caja/issues/detail?id=1775 https://code.google.com/p/google-caja/issues/detail?id=1776 https://code.google.com/p/google-caja/issues/detail?id=1777 Issue 1777 was "fixed" by simply ...
12 years, 8 months ago (2013-06-27 20:37:37 UTC) #7
ihab.awad
https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/guest-manager.js File src/com/google/caja/plugin/guest-manager.js (right): https://codereview.appspot.com/10648043/diff/5001/src/com/google/caja/plugin/guest-manager.js#newcode68 src/com/google/caja/plugin/guest-manager.js:68: if (o.hasOwnProperty(k)) { On 2013/06/27 20:33:26, kpreid2 wrote: > ...
12 years, 8 months ago (2013-06-27 20:38:57 UTC) #8
ihab.awad
12 years, 8 months ago (2013-06-27 20:48:49 UTC) #9
@5462
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b