Issue 106480044: Add equality comparison to EqualToTolowerString.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106480044: Add equality comparison to EqualToTolowerString. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by Rouslan Solomakhin

Modified:
9 years, 10 months ago

Reviewers:
roubert (google)

CC:
lararennie, keghani, davinci_google, dbeaumont

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add equality comparison to EqualToTolowerString. Chromium browser tests on Windows in debug mode have exposed that std::equal is not safe. It should be used only after a length comparison. (Bot failures can be seen at http://goo.gl/qvaBg3, http://goo.gl/j89rgZ, and http://goo.gl/CxcyYm.) TBR=roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=300

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	cpp/src/util/cctype_tolower_equal.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Rouslan Solomakhin

Committed patchset #1 manually as r300 (presubmit successful).

9 years, 10 months ago (2014-07-07 22:44:36 UTC) #2

roubert (google)

LGTM Oh, my, this is embarrassing ... It doesn't really have anything to do with ...

9 years, 10 months ago (2014-07-08 18:41:38 UTC) #3

Message was sent while issue was closed.

No worries, it happens to the best of us :-)

Expand All Messages | Collapse All Messages