src/pkg/runtime/slice.goc - Issue 106260045: code review 106260045: runtime: simpler and faster GC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/slice.goc

Issue 106260045: code review 106260045: runtime: simpler and faster GC (Closed)

Patch Set: diff -r d4f4fb0e307c https://dvyukov%40google.com@code.google.com/p/go/ Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/slice.goc

===================================================================

--- a/src/pkg/runtime/slice.goc

+++ b/src/pkg/runtime/slice.goc

@@ -126,7 +126,7 @@

// Can't use FlagNoZero w/o FlagNoScan, because otherwise GC can scan unitialized memory.

if(typ->kind&KindNoPointers)

flag = FlagNoScan|FlagNoZero;

- ret->array = runtime·mallocgc(capmem, (uintptr)typ|TypeInfo_Array, flag);

+ ret->array = runtime·mallocgc(capmem, typ, flag);

ret->len = x.len;

ret->cap = newcap1;

lenmem = x.len*typ->size;

« no previous file with comments | « src/pkg/runtime/runtime.h ('k') | src/pkg/runtime/stack.c » ('j') | no next file with comments »