state/apiserver: rename State to Pinger

state/apiserver: rename State to Pinger

It doesn't make much sense to call it "State" when
it's only used for pinging.

Also increase the ping interval - there's no need to
hammer the servers.

https://code.launchpad.net/~rogpeppe/juju-core/334-apiserver-pinger/+merge/171609

(do not edit description out of merge proposal)

[rog, 2013-06-26 16:54:58]

Please take a look.

[dimitern, 2013-06-26 17:20:00]

LGTM with some suggestions.

https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go#newc...
state/api/apiclient.go:20: var PingPeriod = 5 * time.Minute
As discussed online, make this 1 minute please.

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test.go
File state/apiserver/pinger_test.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test...
state/apiserver/pinger_test.go:1: // Copyright 2012, 2013 Canonical Ltd.
I don't see a change here in the diff - what has changed?

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/root.go
File state/apiserver/root.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/root.go#new...
state/apiserver/root.go:188: func (r srvPinger) Ping() {}
// Ping is a no-op used by client heartbeat monitor. ?

[fwereade, 2013-06-26 17:21:52]

LGTM

[rog, 2013-06-26 18:23:46]

Please take a look.

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test.go
File state/apiserver/pinger_test.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test...
state/apiserver/pinger_test.go:1: // Copyright 2012, 2013 Canonical Ltd.
On 2013/06/26 17:20:00, dimitern wrote:
> I don't see a change here in the diff - what has changed?

the file name changed from state_test.go to pinger_test.go

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/root.go
File state/apiserver/root.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/apiserver/root.go#new...
state/apiserver/root.go:188: func (r srvPinger) Ping() {}
On 2013/06/26 17:20:00, dimitern wrote:
> // Ping is a no-op used by client heartbeat monitor. ?

Done.

[rog, 2013-06-26 18:23:56]

https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go#newc...
state/api/apiclient.go:20: var PingPeriod = 5 * time.Minute
On 2013/06/26 17:20:00, dimitern wrote:
> As discussed online, make this 1 minute please.

Done.