Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 10620043: state/apiserver: rename State to Pinger

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by rog
Modified:
12 years, 8 months ago
Reviewers:
mp+171609, dimitern, fwereade
Visibility:
Public.

Description

state/apiserver: rename State to Pinger It doesn't make much sense to call it "State" when it's only used for pinging. Also increase the ping interval - there's no need to hammer the servers. https://code.launchpad.net/~rogpeppe/juju-core/334-apiserver-pinger/+merge/171609 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: rename State to Pinger #

Total comments: 6

Patch Set 3 : state/apiserver: rename State to Pinger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/apiclient.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M state/apiserver/pinger_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M state/apiserver/root.go View 1 2 3 chunks +8 lines, -14 lines 0 comments Download
D state/apiserver/state.go View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
12 years, 8 months ago (2013-06-26 16:54:58 UTC) #1
dimitern
LGTM with some suggestions. https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go File state/api/apiclient.go (right): https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go#newcode20 state/api/apiclient.go:20: var PingPeriod = 5 * ...
12 years, 8 months ago (2013-06-26 17:20:00 UTC) #2
fwereade
LGTM
12 years, 8 months ago (2013-06-26 17:21:52 UTC) #3
rog
Please take a look. https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test.go File state/apiserver/pinger_test.go (right): https://codereview.appspot.com/10620043/diff/3001/state/apiserver/pinger_test.go#newcode1 state/apiserver/pinger_test.go:1: // Copyright 2012, 2013 Canonical ...
12 years, 8 months ago (2013-06-26 18:23:46 UTC) #4
rog
12 years, 8 months ago (2013-06-26 18:23:56 UTC) #5
https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/10620043/diff/3001/state/api/apiclient.go#newc...
state/api/apiclient.go:20: var PingPeriod = 5 * time.Minute
On 2013/06/26 17:20:00, dimitern wrote:
> As discussed online, make this 1 minute please.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b