Issue 106180045: Increase cmake minimium requirment to 2.8.10.1 for crbug.com/159092

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106180045: Increase cmake minimium requirment to 2.8.10.1 for crbug.com/159092 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by zhaoqin

Modified:
11 years, 4 months ago

Reviewers:
bruening

CC:
drmemory-devs_googlegroups.com

Base URL:
https://drmemory.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Increase cmake minimium requirment to 2.8.10.1 for crbug.com/159092 R=bruening@google.com BUG=crbug.com/159092 Committed: https://code.google.com/p/drmemory/source/detail?r=1958

Patch Set 2 : update comment #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	CMakeLists.txt	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

LGTM if comment is addressed https://codereview.appspot.com/106180045/diff/1/CMakeLists.txt File CMakeLists.txt (right): https://codereview.appspot.com/106180045/diff/1/CMakeLists.txt#newcode22 CMakeLists.txt:22: # We need 2.8.10.1 ...

11 years, 4 months ago (2014-06-25 16:24:58 UTC) #2

zhaoqin

11 years, 4 months ago (2014-06-25 17:46:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1958 (presubmit successful).

Expand All Messages | Collapse All Messages