LGTM Thanks for pointing me to the discussion on chromium-dev. After skimming through the thread ...
12 years, 6 months ago
(2013-06-27 06:50:40 UTC)
#2
LGTM
Thanks for pointing me to the discussion on chromium-dev. After skimming through
the thread I understand why there are some discussions regarding the UI changes
and I agree to some of the arguments there.
On 2013/06/27 06:50:40, Andi wrote: > LGTM > > Thanks for pointing me to the ...
12 years, 6 months ago
(2013-06-27 15:40:31 UTC)
#3
On 2013/06/27 06:50:40, Andi wrote:
> LGTM
>
> Thanks for pointing me to the discussion on chromium-dev. After skimming
through
> the thread I understand why there are some discussions regarding the UI
changes
> and I agree to some of the arguments there.
Thanks! Mind committing this patch (or is there a better way to commit patches
for rietveld)? :)
Am Donnerstag, 27. Juni 2013 schrieb : > On 2013/06/27 06:50:40, Andi wrote: > >> ...
12 years, 6 months ago
(2013-06-27 15:53:52 UTC)
#4
Am Donnerstag, 27. Juni 2013 schrieb :
> On 2013/06/27 06:50:40, Andi wrote:
>
>> LGTM
>>
>
> Thanks for pointing me to the discussion on chromium-dev. After
>>
> skimming through
>
>> the thread I understand why there are some discussions regarding the
>>
> UI changes
>
>> and I agree to some of the arguments there.
>>
>
> Thanks! Mind committing this patch (or is there a better way to commit
> patches for rietveld)? :)
It's already committed and live on this instance. Let me know if you're
missing something!
--Andi
>
>
https://codereview.appspot.**com/10617044/<https://codereview.appspot.com/106...
>
On 2013/06/27 15:53:52, Andi wrote: > Am Donnerstag, 27. Juni 2013 schrieb : > > ...
12 years, 6 months ago
(2013-06-27 15:56:50 UTC)
#5
On 2013/06/27 15:53:52, Andi wrote:
> Am Donnerstag, 27. Juni 2013 schrieb :
>
> > On 2013/06/27 06:50:40, Andi wrote:
> >
> >> LGTM
> >>
> >
> > Thanks for pointing me to the discussion on chromium-dev. After
> >>
> > skimming through
> >
> >> the thread I understand why there are some discussions regarding the
> >>
> > UI changes
> >
> >> and I agree to some of the arguments there.
> >>
> >
> > Thanks! Mind committing this patch (or is there a better way to commit
> > patches for rietveld)? :)
>
>
> It's already committed and live on this instance. Let me know if you're
> missing something!
Oh, sweet! Thanks!
Issue 10617044: Decorate section headers in review list.
Created 12 years, 6 months ago by sadrul
Modified 12 years, 6 months ago
Reviewers: Andi
Base URL:
Comments: 0