Add lookup table in PreloadSupplier for natural and Latin script names.

Add lookup table in PreloadSupplier for natural and Latin script names.

Normally the address metadata server takes care of mapping from natural
language names to metadata IDs (eg. "São Paulo" -> "SP") and from Latin
script names to local script names (eg. "Tokushima" -> "徳島県").

As the PreloadSupplier doesn't contact the metadata server upon each
Supply() request, it does instead need to have an internal lookup table
that contains such mappings in order to be possible to use to validate
addresses that use natural language names or Latin script names.

R=rouslan@chromium.org
BUG=

Committed: https://code.google.com/p/libaddressinput/source/detail?r=286

[Rouslan Solomakhin, 2014-06-17 22:41:53]

LGTM, thank you!

[roubert (google), 2014-06-17 22:50:34]

Committed patchset #1 manually as r286 (presubmit successful).

[lararennie, 2014-06-18 08:02:01]

I don't think this is necessarily the right approach, since now we essentially
require a particular implementation of Supplier to make validation work.

https://codereview.appspot.com/105920047/diff/1/cpp/src/preload_supplier.cc
File cpp/src/preload_supplier.cc (right):

https://codereview.appspot.com/105920047/diff/1/cpp/src/preload_supplier.cc#n...
cpp/src/preload_supplier.cc:136: * Normally the address metadata server takes
care of mapping from natural
This comment should be changed. What is the "address metadata server"? The i18n
appspot server does *not* do this.

If the address validator is using a Supplier in general, not a PreloadSupplier,
then it seems to me that we should either:
a) normalize the look-up key in the validator, which is what we do in GWT, or
b) ensure that all implementations of Supplier do this normalization - hard
since it is just an interface.

[Rouslan Solomakhin, 2014-06-18 18:32:50]

Maybe we can make on-demand supplier resolve the natural and Latin script names?