Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 105820044: Restore the accidentally deleted extra_check_functions in cpplint.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by avakulenko
Modified:
10 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
Mark Mentovai, erg
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Restore the accidentally deleted extra_check_functions in cpplint.py This extra parameter was used when calling cpplint.ProcessFile directly from depot_tools/gcl.py and depot_tools/git_cl.py. Restoring it... R=erg@google.com Committed: https://code.google.com/p/google-styleguide/source/detail?r=134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M cpplint/cpplint.py View 9 chunks +23 lines, -8 lines 0 comments Download

Messages

Total messages: 3
avakulenko
The CQ break in depot_tools WAS actually due to my previous change. Without understanding where ...
10 years, 5 months ago (2014-06-04 22:33:31 UTC) #1
Elliot Glaysher
lgtm
10 years, 5 months ago (2014-06-04 22:44:49 UTC) #2
avakulenko
10 years, 5 months ago (2014-06-04 22:48:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r134 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b