Issue 105820044: Restore the accidentally deleted extra_check_functions in cpplint.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105820044: Restore the accidentally deleted extra_check_functions in cpplint.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by avakulenko

Modified:
10 years, 3 months ago

Reviewers:
Elliot Glaysher

CC:
Mark Mentovai, erg

Base URL:
http://google-styleguide.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Restore the accidentally deleted extra_check_functions in cpplint.py This extra parameter was used when calling cpplint.ProcessFile directly from depot_tools/gcl.py and depot_tools/git_cl.py. Restoring it... R=erg@google.com Committed: https://code.google.com/p/google-styleguide/source/detail?r=134

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
	M	cpplint/cpplint.py	View		9 chunks	+23 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

avakulenko

The CQ break in depot_tools WAS actually due to my previous change. Without understanding where ...

10 years, 3 months ago (2014-06-04 22:33:31 UTC) #1

avakulenko

10 years, 3 months ago (2014-06-04 22:48:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r134 (presubmit successful).

Expand All Messages | Collapse All Messages