Return 404 for attachments if parent is unavailable or deleted

Return 404 for attachments if parent is unavailable or deleted

Code Commit : https://code.google.com/p/plexi/source/detail?r=37ec78244914c552fcc1a119be94a297ab1b2cff&repo=sharepoint

[Tanmay Vartak, 2014-06-03 19:03:58]

https://codereview.appspot.com/105790045/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/105790045/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2348: if
("0".equals(itemCount)) {
ItemCount will be 0 if parent list item is deleted or unavailable (one such
scenario is Rejected list item). We are just returning false here but not
marking response as Not found. This is to avoid wrongly identifying documents as
"Attachment documents" when regular document library contains folder name
"Attachments"

[pjo, 2014-06-03 19:17:32]

On 2014/06/03 19:03:58, Tanmay Vartak wrote:
>
https://codereview.appspot.com/105790045/diff/1/src/com/google/enterprise/ada...
> File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
> (right):
> 
>
https://codereview.appspot.com/105790045/diff/1/src/com/google/enterprise/ada...
> src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2348: if
> ("0".equals(itemCount)) {
> ItemCount will be 0 if parent list item is deleted or unavailable (one such
> scenario is Rejected list item). We are just returning false here but not
> marking response as Not found. This is to avoid wrongly identifying documents
as
> "Attachment documents" when regular document library contains folder name
> "Attachments"

Consider adding this annotation to the code itself.

[pjo, 2014-06-03 19:17:39]

LGTM.  Thank you