Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 10576043: fix flakiness in cajajs-minor-version-skew tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by felix8a
Modified:
12 years, 8 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The version skew tests rely on making a set of caja js files that have the wrong version number, so instead of version 4650 the files would claim to be version 0000 or 4650mmm. These files are created by string-replacing the current version 4650 with the fake version. The flakiness happens when there are false positive matches, like es53-taming-frame.js could have 'cajoledDate':1372196894650 which is harmless when 4650 becomes 0000, but causes a js syntax error when 4650 becomes 4650mmm. This fixes the flakiness by making the version substitution precise.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M build.xml View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 8 months ago (2013-06-25 23:25:53 UTC) #1
kpreid2
LGTM Good. This should also fix non-SVN-tree builds going wrong if they use "exported" as ...
12 years, 8 months ago (2013-06-25 23:33:51 UTC) #2
felix8a
12 years, 8 months ago (2013-06-25 23:39:40 UTC) #3
@r5461
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b