Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 105760044: Bundle changes for HM9000

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by johnsca
Modified:
11 years ago
Reviewers:
mp+221772, benjamin.saller
Visibility:
Public.

Description

Bundle changes for HM9000 Obviously, charm path changes are temporary for testing and will need to be changed prior to merging. https://code.launchpad.net/~johnsca/charms/bundles/cloudfoundry/hm9k/+merge/221772 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M bundles.yaml View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 3
johnsca
Please take a look.
11 years ago (2014-06-02 17:52:43 UTC) #1
benjamin.saller
LGTM thanks. I'm a little wary of depending on charms outside of our namespace, but ...
11 years ago (2014-06-02 18:32:47 UTC) #2
johnsca
11 years ago (2014-06-02 19:09:46 UTC) #3
On 2014/06/02 18:32:47, benjamin.saller wrote:
> LGTM thanks.
> 
> I'm a little wary of depending on charms outside of our namespace, but we can
> change this once you merge up your branch. I'd suggest pushing hm9000 into our
> namespace and then updating the reference here before landing. As for etcd, I
> don't think that makes sense to fork, but we should push to get it into the
> store sooner than later.

Yeah, the bundle changes were just to show what would need to be added for the
HM9k charm, and for testing purposes.  I fully expected it to change to
cf-charmers / store links before merging this, as I tried to convey in the
review description.

I used hazmat's etcd since there wasn't one ready in cf-charmers, but there's a
proposed one using the services framework that we can evaluate as well.  But
hazmat's version works currently, so I'm ok just getting that into the store.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b