Issue 105670044: ticket:10944: Update ICUBinaryTest to test readHeader(ByteBuffer).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 105670044: ticket:10944: Update ICUBinaryTest to test readHeader(ByteBuffer). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by roubert (google)

Modified:
10 years, 5 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk

Visibility:
Public.

More Reviews

Description

ticket:10944: Update ICUBinaryTest to test readHeader(ByteBuffer). Testing readHeader(InputStream) is no longer of any importance, as the use of that method is going away. This also exposes a bug in the test data; the size field was zero. Also add statement to actually test lenient data version. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/36032

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. #

Patch Set 3 : Update copyright formatting. #

Patch Set 4 : Rebase. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -26 lines)			Patch
	M	main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java	View	1 2	4 chunks	+26 lines, -26 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

LGTM https://codereview.appspot.com/105670044/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java File main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java (right): https://codereview.appspot.com/105670044/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java#newcode97 main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java:97: // lenient data version Your changes here are ...

10 years, 5 months ago (2014-07-11 17:27:25 UTC) #2

roubert (google)

https://codereview.appspot.com/105670044/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java File main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java (right): https://codereview.appspot.com/105670044/diff/1/main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java#newcode97 main/tests/core/src/com/ibm/icu/dev/test/util/ICUBinaryTest.java:97: // lenient data version On 2014/07/11 17:27:25, markus.icu wrote: ...

10 years, 5 months ago (2014-07-14 15:00:55 UTC) #3

roubert (google)

10 years, 5 months ago (2014-07-15 20:11:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r36032 (presubmit successful).

Expand All Messages | Collapse All Messages