Public storage in the Azure provider

Public storage in the Azure provider

This branch adds support for a public storage in the Azure provider.  It introduces two new configuration items (public-storage-account-name and public-storage-container-name) which, together, will be used to create an anonymous gwacl.storageContext object (i.e. one with an empty access Key) used to retrieve the tools.  The key point is the implementation of the storage's URL() method which, given that it's going to be used to access a public container in Azure, is simply the file URL as returned by gwacl's GetFileURL() method; when a container is public, files in there can simply be retrieved using wget.

Drive-by fix: get rid of the recently introduced NewStorage method and instead, implement environ's Storage() method.

https://code.launchpad.net/~rvb/juju-core/az-public-storage/+merge/171251

(do not edit description out of merge proposal)

[rvb, 2013-06-25 13:36:07]

Please take a look.

[mue, 2013-06-25 14:47:13]

LGTM with one comment.

https://codereview.appspot.com/10541044/diff/1/environs/azure/storage_test.go
File environs/azure/storage_test.go (right):

https://codereview.appspot.com/10541044/diff/1/environs/azure/storage_test.go...
environs/azure/storage_test.go:181: func (StorageSuite) TestURL(c *C) {
This test re-implements the implementation. Would prefer a comparison with an
external defined URL.

[rvb, 2013-06-25 15:48:01]

On 2013/06/25 14:47:13, mue wrote:
> LGTM with one comment.
> 
> https://codereview.appspot.com/10541044/diff/1/environs/azure/storage_test.go
> File environs/azure/storage_test.go (right):
> 
>
https://codereview.appspot.com/10541044/diff/1/environs/azure/storage_test.go...
> environs/azure/storage_test.go:181: func (StorageSuite) TestURL(c *C) {
> This test re-implements the implementation. Would prefer a comparison with an
> external defined URL.

Good point, fixed.

Thanks for the review!

[jtv.canonical, 2013-06-25 16:04:25]

LGTM