Issue 10522044: Add cc to search

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10522044: Add cc to search

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bradfitz

Modified:
12 years, 6 months ago

Reviewers:
Andi

Visibility:
Public.

More Reviews

Description

Add cc to search

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	codereview/views.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Andi

12 years, 6 months ago (2013-06-25 03:37:07 UTC) #2

On 2013/06/25 03:17:17, Andi wrote:
> Committed as f556795e107b and live.
> 
> Thanks!

FYI, I've missed one thing. cc is not defined in the form class, therefore it's
not always present in form.cleaned_data. I've already applied a fix here:
https://code.google.com/p/rietveld/source/detail?r=c9e95d7a0934302b46f757b2c6...

Expand All Messages | Collapse All Messages