Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 105105: Invoke RPC call only if the perfs changed in gadgets.Prefs.prototype.set(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by deanliao
Modified:
10 years, 9 months ago
Reviewers:
shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

It is a solution to a Shindig issue: https://issues.apache.org/jira/browse/SHINDIG-1154 . It reduce unnecessary RPC calls issued by gadgets.Prefs.prototype.set().

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M features/src/main/javascript/features/core/prefs.js View 1 chunk +11 lines, -1 line 0 comments Download
M features/src/main/javascript/features/setprefs/setprefs.js View 2 chunks +6 lines, -2 lines 0 comments Download
M features/src/test/javascript/features/core/prefstest.js View 1 chunk +16 lines, -0 lines 0 comments Download
M features/src/test/javascript/features/setprefs/setprefstest.js View 4 chunks +32 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b