Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 105103: Fully init SkPaints.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by agl
Modified:
12 years, 1 month ago
Reviewers:
reed
Visibility:
Public.

Description

Fully init SkPaints. On 32-bit Linux, the current SkPaint structure is 60 bytes long. However, the last two bytes of that are just padding and the current SkPaint constructor never modifies them. But, when calling SkPaint::operator==, the memcmp is performed over the whole structure, including the random padding bytes and will often fail. For example: SkPaint a, b; if (a == b) { ... is undefined without this patch.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkPaint.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1
agl
12 years, 1 month ago (2009-08-13 17:52:19 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b