Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(484)

Issue 105100050: time: avoid broken fix for buggy TestOverflowRuntimeTimer

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by r
Modified:
11 years, 7 months ago
Reviewers:
rsc
CC:
golang-codereviews
Visibility:
Public.

Description

time: avoid broken fix for buggy TestOverflowRuntimeTimer The test requires that timerproc runs, but busy loops and starves the scheduler so that, with high probability, timerproc doesn't run. Avoid the issue by expecting the test to succeed; if not, a major outside timeout will kill it and let us know. As you can see from the diffs, there have been several attempts to fix this with chicanery, but none has worked. Don't bother trying any more. Fixes issue 8136.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -44 lines) Patch
src/pkg/time/internal_test.go View 3 chunks +9 lines, -41 lines 0 comments Download
src/pkg/time/sleep_test.go View 1 chunk +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b