state/apiserver/client: new package

state/apiserver/client: new package

We factor it out of the api server.
This is a step on the way to showing each
kind of API client a customised API.

https://code.launchpad.net/~rogpeppe/juju-core/327-apiserver-factor-out-client/+merge/171065

Requires: https://code.launchpad.net/~rogpeppe/juju-core/320-apiserver-login-choose-api/+merge/170939

(do not edit description out of merge proposal)

[rog, 2013-06-25 16:12:09]

Please take a look.

[rog, 2013-06-25 16:13:18]

Please take a look.

[fwereade, 2013-06-26 14:43:54]

Nice, LGTM

https://codereview.appspot.com/10494043/diff/9001/state/apiserver/client/clie...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/10494043/diff/9001/state/apiserver/client/clie...
state/apiserver/client/client_test.go:492: return mockStore, func() {
client.CharmStore = origStore }
What's the justification for this BTW? We've got a perfectly good charm store
global elsewhere? Doesn't need fixing this branch, but it'd be good to know if
it's open season on it.

[dimitern, 2013-06-26 14:57:31]

LGTM

[rog, 2013-06-26 15:02:08]

https://codereview.appspot.com/10494043/diff/9001/state/apiserver/client/clie...
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/10494043/diff/9001/state/apiserver/client/clie...
state/apiserver/client/client_test.go:492: return mockStore, func() {
client.CharmStore = origStore }
On 2013/06/26 14:43:54, fwereade wrote:
> What's the justification for this BTW? We've got a perfectly good charm store
> global elsewhere? Doesn't need fixing this branch, but it'd be good to know if
> it's open season on it.

changing the global would seem fine to me. i don't know why it was done this
way.