environs/ec2/ec2.go - Issue 10492043: environs/*: access environ name safely

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: environs/ec2/ec2.go

Issue 10492043: environs/*: access environ name safely

Patch Set: environs/*: access environ name safely Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: environs/ec2/ec2.go

=== modified file 'environs/ec2/ec2.go'

--- environs/ec2/ec2.go 2013-06-19 00:15:01 +0000

+++ environs/ec2/ec2.go 2013-06-24 10:55:04 +0000

@@ -147,6 +147,7 @@

if err != nil {

return nil, err

}

+ e.name = cfg.Name()

return e, nil

}

@@ -185,7 +186,6 @@

}

e.ecfgMutex.Lock()

defer e.ecfgMutex.Unlock()

- e.name = ecfg.Name()

e.ecfgUnlocked = ecfg

auth := aws.Auth{ecfg.accessKey(), ecfg.secretKey()}

« no previous file with comments | « [revision details] ('k') | environs/maas/environ.go » ('j') | no next file with comments »