Issue 104910045: move accessor binding into polymer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104910045: move accessor binding into polymer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rafaelw

Modified:
11 years, 8 months ago

Reviewers:
sorvell, sjmiles

Base URL:
git@github.com:Polymer/polymer-dev.git@master

Visibility:
Public.

More Reviews

Description

move accessor binding into polymer Note that this patch just moves code from observe-js into polymer (with slight tweaks). Follow-on work pending: -dont force creation of an array literal for registerObservers -cleanUp the close*Observer mess -add asserts to unbind tests that zero observers are active -allow computed properties to be bindable sorvell BUG= R=sorvell@google.com Committed: https://github.com/Polymer/polymer-dev/commit/2248f84

Patch Set 1 #

Patch Set 2 : cleanuo #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -57 lines)			Patch
M	src/declaration/properties.js	View		1 chunk	+32 lines, -1 line	0 comments	Download
M	src/instance/properties.js	View		5 chunks	+83 lines, -19 lines	0 comments	Download
A	test/html/bindProperties.html	View	1	1 chunk	+93 lines, -0 lines	0 comments	Download
M	test/js/bindProperties.js	View		1 chunk	+1 line, -37 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rafaelw

11 years, 8 months ago (2014-06-09 23:30:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r2248f84 (presubmit successful).

Expand All Messages | Collapse All Messages