Issue 10480045: Azure Open(), and change to 'name' attribute.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10480045: Azure Open(), and change to 'name' attribute. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by jtv.canonical

Modified:
12 years, 6 months ago

Reviewers:
mp+171241, rvb, dave, rog

Visibility:
Public.

Description

Azure Open(), and change to 'name' attribute. The Open() part is not very interesting. We don't have a NewStorage() yet so can't do that yet. Some providers have a separate NewEnviron(), called from Open(), but that didn't look particularly useful just yet. What is interesting is that the environ's ‘name’ attribute is now initialized from Open(), and not from SetConfig(). This is in alignment with what Roger Peppe is doing on the other providers, to squelch a subtle concurrency bug where the attribute got rewritten with the same value on every config change, even though it's read outside the lock. https://code.launchpad.net/~jtv/juju-core/az-open/+merge/171241 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Azure Open(), and change to 'name' attribute. #

Total comments: 2

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -20 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/azure/environ.go	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	environs/azure/environ_test.go	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	environs/azure/environprovider.go	View	2 chunks	+5 lines, -1 line	2 comments	Download
A	environs/azure/environprovider_test.go	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/06/25 09:09:14, jtv.canonical wrote: > Please take a look. Sorry, error: old chunk mismatch ...

12 years, 8 months ago (2013-06-26 05:39:18 UTC) #2

rog

LGTM modulo the below comment. I'd prefer to lose the conditional and thus make the ...

12 years, 8 months ago (2013-06-26 13:18:15 UTC) #5

rog

12 years, 8 months ago (2013-06-26 13:31:23 UTC) #6

LGTM!

https://codereview.appspot.com/10480045/diff/6001/environs/azure/environprovi...
File environs/azure/environprovider.go (right):

https://codereview.appspot.com/10480045/diff/6001/environs/azure/environprovi...
environs/azure/environprovider.go:23: return &env, env.SetConfig(cfg)
On 2013/06/26 13:18:15, rog wrote:
> wouldn't it be easier (with less moving parts) to simply initialise env.name
> here, the approach I took in the other providers?

scratch that; i'm obviously on crack.

Expand All Messages | Collapse All Messages