Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2551)

Issue 104800043: replicaset/initiate: wait for status from initiate

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by mfoord
Modified:
9 years, 11 months ago
Reviewers:
mp+221709, natefinch, fwereade
Visibility:
Public.

Description

replicaset/initiate: wait for status from initiate After replicaset initiation wait (briefly) for a status check to return successfully. Hopefully this will fix the problems with bootstrap on precise for slow machines. It also means we won't attempt to use the database until we know the replicaset is ready. https://code.launchpad.net/~mfoord/juju-core/slow-replset/+merge/221709 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : replicaset/initiate: wait for status from initiate #

Patch Set 3 : replicaset/initiate: wait for status from initiate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M replicaset/replicaset.go View 1 2 3 chunks +17 lines, -0 lines 0 comments Download
M replicaset/replicaset_test.go View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mfoord
Please take a look.
9 years, 11 months ago (2014-06-02 11:30:34 UTC) #1
fwereade
https://codereview.appspot.com/104800043/diff/1/replicaset/replicaset.go File replicaset/replicaset.go (right): https://codereview.appspot.com/104800043/diff/1/replicaset/replicaset.go#newcode74 replicaset/replicaset.go:74: config, err = CurrentConfig(monotonicSession) I am strongly inclined to ...
9 years, 11 months ago (2014-06-02 13:04:17 UTC) #2
mfoord
Please take a look.
9 years, 11 months ago (2014-06-02 16:04:06 UTC) #3
mfoord
Please take a look.
9 years, 11 months ago (2014-06-02 16:07:25 UTC) #4
natefinch
9 years, 11 months ago (2014-06-02 16:24:00 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b