Issue 104620043: Fix ibus-setup SEGV in enginetreeview.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104620043: Fix ibus-setup SEGV in enginetreeview.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by fujiwara

Modified:
9 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix ibus-setup SEGV in enginetreeview.py When an engine is added on ibus-setup, enginetreeview.append_engine() calls self.__model.append(None) and it causes engine == None in __icon_cell_data_cb() and __name_cell_data_cb() in enginetreeview with python3-gobject 3.13.x which version has implemented several deprecated warnings in gi/overrides/Gtk.py . I think this problem also could happen in the old versions if the system would be slow. BUG=rhbz#1048429 TEST=setup in Fedora 21

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	setup/enginetreeview.py	View		3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages